hsfz: Improve alive check dissection.#4760
Merged
Merged
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #4760 +/- ##
==========================================
- Coverage 82.16% 82.16% -0.01%
==========================================
Files 362 362
Lines 87359 87361 +2
==========================================
+ Hits 71777 71778 +1
- Misses 15582 15583 +1
🚀 New features to boost your workflow:
|
antoniovazquezblanco
force-pushed
the
hsfz
branch
from
47aa301 to
d60fe21
Compare
polybassa
approved these changes
Jun 2, 2025
Contributor
Author
|
Thanks for the approval @polybassa! :D |
Contributor
Author
|
Thanks! :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist:
cd test && ./run_testsortox)Improve HSFZ alive check packet dissection.
I am not a thousend percent on the short alive check frames structure (having addresses) but that is the best idea I've got regarding those two bytes...